Migrate Dagger/Hilt to KSP

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for android that you can either build or download from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.64k stars 602 forks source link

Migrate Dagger/Hilt to KSP #2682

Closed ILIYANGERMANOV closed 11 months ago

ILIYANGERMANOV commented 11 months ago

Please confirm the following

[X] I checked the current issues for duplicate issues.

What would you like to improve?

Migrate Hilt to KSP
Get rid of KAPT entirely
The project to build faster and still work properly

Because...

KSP is faster than KAPT

Description

https://dagger.dev/dev-guide/ksp.html

Success Criteria

Hilt is migrated to KSP
The project builds successfully
All of the CI checks still work and pass
There are no runtime crashes in the app
We no longer use KSP

aritra-tech commented 11 months ago

I will try to pick this one.

lovemhjn commented 11 months ago

@aritra-tech Let me know if you face any issue. @ILIYANGERMANOV Can i pick this if @aritra-tech faces any issues as i have recently migrated one of my project from hilt kapt to ksp

ILIYANGERMANOV commented 11 months ago

Hey @lovemhjn sure, if @aritra-tech has any difficulties and can't submit a PR till Tuesday EOD feel free to take it 👍 You can also communicate with each other and support each other. I should add this to the contributing rules but I'm planning on defining a general 1-2 days deadline for each task.

aritra-tech commented 11 months ago

Hey, @ILIYANGERMANOV actually I'm stuck with my office work so please assign this issue to @lovemhjn. Thank you.

ILIYANGERMANOV commented 11 months ago

Hey, @ILIYANGERMANOV actually I'm stuck with my office work so please assign this issue to @lovemhjn. Thank you.

Got it. Thank you for pinging us @aritra-tech! Appreciated. @lovemhjn - it's yours now

lovemhjn commented 11 months ago

@ILIYANGERMANOV Pr for migration https://github.com/Ivy-Apps/ivy-wallet/pull/2699