[FEATURE] Change the keypad layout

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for android that you can either build or download from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.64k stars 604 forks source link

[FEATURE] Change the keypad layout #3343

Closed Sakchamn closed 1 week ago

Sakchamn commented 1 month ago

Please confirm the following:

[X] I've checked the current issues for duplicate issues.
[X] I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
[x] My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

I've entered the wrong amount while entering the amount for the transactions, as i have been using the traditional android number keypad for a long time, it's hard to adjust to the layout of the application

Why do you need it?

So that whenever a user enters a transaction, they does not enter a wrong transaction in a haste ( for eg, 780 instead of 120)

How do you imagine it?

Change the layout form IMG_20240714_234705 to IMG_20240714_234724

ivywallet commented 1 month ago

Thank you @Sakchamn for raising Issue #3343! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ILIYANGERMANOV commented 1 month ago

There's no standard for this. We changed it a few times back and forth. For now, we follow the pattern on Samsung

Screenshot_20240714_213122_Calculator

ILIYANGERMANOV commented 1 month ago

As a alternative we can have a Settings using the IvyFeatures class for which type of keyboard to show

Sakchamn commented 1 month ago

I'm on it

ivywallet commented 1 month ago

Thank you for your interest @Sakchamn! 🎉 Issue #3343 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ILIYANGERMANOV commented 1 month ago

@Sakchamn make sure that by default Ivy Wallet uses its current keypad format. Only when the setting that you add is enabled then the keypad will change to your proposal. It might be the simplest to create 2 versions of the keypad composable.

ILIYANGERMANOV commented 1 month ago

hey @ILIYANGERMANOV , i've edited the amount modal function, which now takes a boolean parameter to tell whether to use the default keypad format or not, can you guide me how to create settings for the same ? I've tried doing it my self, but got stuck.

@Sakchamn see the IvyFeatures class and add a new called contactsKeypadEnabled or some better name