Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

[BUG] calculation mistake #3411

Open Sailesh777 opened 3 months ago

Sailesh777 commented 3 months ago

Please confirm the following

Describe the bug

When I create an report in the expense section through account transfer amount is also calculated even the option is not selected

To Reproduce

Expected behavior

The calculation to be correct, the account transfer amount shouldn't be added up if the option is not selected

Screenshots

Screenshot_2024-08-17-12-06-35-153_com ivy wallet Screenshot_2024-08-17-12-06-29-112_com ivy wallet Screenshot_2024-08-17-12-06-17-221_com ivy wallet Screenshot_2024-08-17-12-06-14-135_com ivy wallet Screenshot_2024-08-17-12-06-05-661_com ivy wallet Screenshot_2024-08-17-12-05-57-042_com ivy wallet

App version

V4.6.3 (163)

Smartphone

Redme Note 13 pro plus

Additional context

No response

ivywallet commented 3 months ago

Thank you @Sailesh777 for raising Issue #3411! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

shamim-emon commented 2 months ago

I'm on it

ivywallet commented 2 months ago

Thank you for your interest @shamim-emon! 🎉 Issue #3411 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

shamim-emon commented 2 months ago

@ILIYANGERMANOV does this bug exist anymore? Only problem I noticed is if we don't selectTransfers as income expense then it's not added to the total even though it's listed( Is it intended behavior or bug).

In-case I'm missing the original bug please let me know how to re-produce.

https://drive.google.com/file/d/160K_jvJCY9q-j0KwNmwZpQjGQnj1_6od/view?usp=sharing

ILIYANGERMANOV commented 2 months ago

@ILIYANGERMANOV does this bug exist anymore? Only problem I noticed is if we don't selectTransfers as income expense then it's not added to the total even though it's listed( Is it intended behavior or bug).

In-case I'm missing the original bug please let me know how to re-produce.

https://drive.google.com/file/d/160K_jvJCY9q-j0KwNmwZpQjGQnj1_6od/view?usp=sharing

By default transfers shouldn't be considered Income/Expense. Transfers are meant to be a zero-value transactions (e.g. moving money from left to right pocket)

shamim-emon commented 2 months ago

@ILIYANGERMANOV does this bug exist anymore? Only problem I noticed is if we don't selectTransfers as income expense then it's not added to the total even though it's listed( Is it intended behavior or bug).

In-case I'm missing the original bug please let me know how to re-produce.

https://drive.google.com/file/d/160K_jvJCY9q-j0KwNmwZpQjGQnj1_6od/view?usp=sharing

By default transfers shouldn't be considered Income/Expense. Transfers are meant to be a zero-value transactions (e.g. moving money from left to right pocket)

Ok,so that is intended behaviour.

How about the bug mentioned in this issue?Is it still there? Or am I missing any required step to re-produce? (video link given above) .

ILIYANGERMANOV commented 2 months ago

@shamim-emon I have no clue, the issue author @Sailesh777 should test with the latest APK and tell

shamim-emon commented 2 months ago

@shamim-emon I have no clue, the issue author @Sailesh777 should test with the latest APK and tell

Ok. @Sailesh777 please confirm us about it.

Sailesh777 commented 2 months ago

I checked the issue and I found out, if a transaction don't have any category selected the transaction are not shown in the report that's why I felt that the calculation was mistake. So I think the solution would be, while showing the chart, unspecified category is also shown along with other categories.

I hope I am able to explain.

On Fri, 30 Aug 2024, 6:43 pm Shamim Shahrier Emon, @.***> wrote:

@shamim-emon https://github.com/shamim-emon I have no clue, the issue author @Sailesh777 https://github.com/Sailesh777 should test with the latest APK and tell

Ok. @Sailesh777 https://github.com/Sailesh777 please confirm us about it.

— Reply to this email directly, view it on GitHub https://github.com/Ivy-Apps/ivy-wallet/issues/3411#issuecomment-2321169287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDDDWFAXJKSONCDKGWK6G3ZUBT7BAVCNFSM6AAAAABMVEX53GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRRGE3DSMRYG4 . You are receiving this because you were mentioned.Message ID: @.***>