[Domain] Build AccountBalanceUseCase

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.8k stars 675 forks source link

[Domain] Build AccountBalanceUseCase #3418

Closed rodrigoliveirac closed 2 months ago

rodrigoliveirac commented 2 months ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

[x] I've read the Contribution Guidelines and my PR doesn't break the rules.
[x] I've read and understand the Developer Guidelines.
[x] I confirm that I've run the code locally and everything works as expected.
[x] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
[x] 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

Describe with a few bullets what's new:

I've implemented the methods of AccountBalanceUseCase

Does this PR close any GitHub issues? (do not delete)

Closes #3143

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

ILIYANGERMANOV commented 2 months ago

Hey @rodrigoliveirac sorry for all the comments and nitpicking! It's just a core API that we'll use a lot and I want us to make it as simple and elegant as possible 🙌 Btw, great progress - I like the new builder + naming!

rodrigoliveirac commented 2 months ago

Hey @rodrigoliveirac sorry for all the comments and nitpicking! It's just a core API that we'll use a lot and I want us to make it as simple and elegant as possible 🙌 Btw, great progress - I like the new builder + naming!

No need to apologize! I definitely understand the importance of that. I'm enjoying the opportunity to grow with this. Thank you for all!

ILIYANGERMANOV commented 2 months ago

Nice work @rodrigoliveirac 👏 I really start liking this implementation! What's left is cover all cases with tests and fix edge-case. Trust me, property-based tests will uncover ones

rodrigoliveirac commented 2 months ago

Nice work @rodrigoliveirac 👏 I really start liking this implementation! What's left is cover all cases with tests and fix edge-case. Trust me, property-based tests will uncover ones

Sure! I'll do. Thank you! 👊

rodrigoliveirac commented 2 months ago

@ILIYANGERMANOV Is this test structure okay? Quick question just to go ahead

rodrigoliveirac commented 2 months ago

@rodrigoliveirac let's merge this one and you can build on top of it in a follow-up PR 🚀

Ok, I'll still be working in the same branch for that 👊