search

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

[BUG] Incorrect Time Display After Saving Transaction #3424

Open akashs056 opened 2 months ago

akashs056 commented 2 months ago

Please confirm the following

Describe the bug

After adding a transaction (Income or Expence), the correct time and date are initially shown. However, once the transaction is saved and reopened, the displayed time becomes incorrect

Here the reference https://github.com/user-attachments/assets/3ceec8f1-5566-4565-bf56-8a235f2a450e

To Reproduce

  1. Add an income or expense transaction in the app.
  2. Note the time displayed before saving the transaction.
  3. Click "Save" to save the transaction.
  4. Navigate to the home page.
  5. Reopen the saved transaction.
  6. Observe that the time displayed has changed or is incorrect.

Expected behavior

The expected behavior is that the time and date displayed for a transaction should remain consistent and accurate after saving and reopening the transaction. The time noted before saving should match the time shown when the transaction is reopened.

Screenshots

No response

App version

v2024.8.11 (194) from GitHub

Smartphone

Realme 8 Android 11

Additional context

My Time zone : UTC+05:30 ( India )

ivywallet commented 2 months ago

Thank you @akashs056 for raising Issue #3424! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

TDYQ-Liu commented 2 months ago

I also encountered this problem

shamim-emon commented 2 months ago

I'm on it

ivywallet commented 2 months ago

Thank you for your interest @shamim-emon! 🎉 Issue #3424 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ILIYANGERMANOV commented 2 months ago

@shamim-emon for the fix use the classes from #3396 - TimeConverter

lch500 commented 2 months ago

The default time of a new transaction is set to UTC instead of my time zone UTC+8 (time zone of my device has been set to UTC+8 already), and the app will be unable to deduct amount from the account if I change the time of transaction manually.

TDYQ-Liu commented 2 months ago

19:10(UTC+8), display 11:10

ILIYANGERMANOV commented 2 months ago

Got it. I'll rework the EditTransactionViewModel to work with time properly