Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

Fix Incorrect Time Display After Saving Transaction #3433

Closed shamim-emon closed 2 months ago

shamim-emon commented 2 months ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

Risk factors

What may go wrong if we merge your PR?

In what cases won't your code work?

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

shamim-emon commented 2 months ago

Folks, let's do the proper fix by reworking the entire app time handling using the TimeConverter API - small fixes won't solve it - they fix one thing and break another

@ILIYANGERMANOV sure, since this will be a big task, can I create another issue and attach with this PR once goal is reached?

ILIYANGERMANOV commented 2 months ago

Folks, let's do the proper fix by reworking the entire app time handling using the TimeConverter API - small fixes won't solve it - they fix one thing and break another

@ILIYANGERMANOV sure, since this will be a big task, can I create another issue and attach with this PR once goal is reached?

Yeah that makes sense

shamim-emon commented 2 months ago

@ILIYANGERMANOV @akashs056 will reopen PR once done with TimeConverterAPI migration is done successfully.

ILIYANGERMANOV commented 2 months ago

@ILIYANGERMANOV @akashs056 will reopen PR once done with TimeConverterAPI migration is done successfully.

@shamim-emon I have errors in #3435 (the app crashes with Long overflow) and other stuff are broken. I'll see I'll easily fix them. Ideally, at one point we should rewrite the legacy properly and cover it with tests (like the new APIs)