Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

Fix issue 2962 #3477

Closed priyatanu closed 2 months ago

priyatanu commented 2 months ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new: -I've fixed technical debt from the code

Before After
{media} {media}
{media} {media}

Risk factors

What may go wrong if we merge your PR?

In what cases won't your code work?

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

priyatanu commented 2 months ago

https://github.com/user-attachments/assets/7cb90638-6ddd-43ca-bc22-0c1f6f5657d3

Vishwa-Raghavendra commented 2 months ago

@priyatanu a few notes:

  1. Let's not update the CategoryRepo usages in the backup usacase because it seems too dangerous
  2. Let's update CategoryDao -> CategoryRepo on all other places in the app

Also the dao layer deals with entity classes while repo layer deals with domain classes old backups will start failing