Closed akashs056 closed 2 months ago
@ILIYANGERMANOV I’ve migrated the default time picker to the new one, but I’m facing an issue. When I update the time from the ViewModel using the loan record dateTime, it works fine in edit mode. However, when creating a new record and loanRecordModalData.value.loanRecord
is null, the time doesn’t update properly. Should I create a separate state for handling this time, or do you have any other suggestions? Please take a look at the code.
@ILIYANGERMANOV I’ve migrated the default time picker to the new one, but I’m facing an issue. When I update the time from the ViewModel using the loan record dateTime, it works fine in edit mode. However, when creating a new record and
loanRecordModalData.value.loanRecord
is null, the time doesn’t update properly. Should I create a separate state for handling this time, or do you have any other suggestions? Please take a look at the code.
handling for save and edit scenarios is present here
Provide a screen recording after the latest changes and we can merge
The latest changes is not working as expected see i am commented the issue oi am facing please suggest your opinion should i modify the states or any other approach.....
Screen recording of my latest changes and works perfectly fine
https://github.com/user-attachments/assets/8efdca7a-c29d-4114-8fe9-3f4044425864
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
https://github.com/user-attachments/assets/349091c1-3b90-4aea-931b-1f55376d3bfe
What's changed?
used the new Time Provider APIs
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.