Search Functionality In Category Screen - Githubissues

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.8k stars 675 forks source link

Search Functionality In Category Screen #3499

Closed shamim-emon closed 2 months ago

shamim-emon commented 2 months ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

[x] I've read the Contribution Guidelines and my PR doesn't break the rules.
[x] I've read and understand the Developer Guidelines.
[x] I confirm that I've run the code locally and everything works as expected.
[x] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
[x] 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

I have added optional search functionality in Category Screen

https://github.com/user-attachments/assets/6fa8c504-7433-4bcb-96c1-e42685fdaa84

Does this PR close any GitHub issues? (do not delete)

Closes #3488

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

ILIYANGERMANOV commented 2 months ago

@shinebrillant great work! As a feedback, try putting meaningful commit message describing the change in the commit briefly l:

"fix-issue-3488" 12 times isn't very helpful for reviewers