Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

[BUG] Static time zone (set to GMT 0/UTC) of transaction times when importing a CSV file. #3500

Open AshodSathsara opened 2 months ago

AshodSathsara commented 2 months ago

Please confirm the following

Describe the bug

Time of the imported transactions are automatically set to UTC time.

(Imported from a wallet by budgetbakers CSV file, with 480 transactions)

To Reproduce

  1. Import a CSV file in which the time zone is not in GMT 0:00 (or UTC).

Expected behavior

Imported transaction times should be the same as what's in the CSV file.

(I'm in GMT +5:30 time zone, and all the transactions in the imported CSV file as well. The importing process automatically reduced the time by 5.5 hours to match the UTC time for each transaction.)

Screenshots

Screenshot_2024-09-13-18-47-22-583_com ivy wallet Screenshot_2024-09-13-18-51-14-033_com ivy wallet-edit

App version

v2024.09.01 (196)

Smartphone

Redmi Note 12

Additional context

I've seen this time zone problem on previous bug reports with the exact same UTC timing when setting reccuring transactions, but I did not come across anyone mentioning this issue when importing.

The date of the transaction sometimes being a day off most likely have to do with this time zone issue.

ivywallet commented 2 months ago

Thank you @AshodSathsara for raising Issue #3500! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ILIYANGERMANOV commented 2 months ago

Make sure that this fix doesn't break new and old backups. If that's impossible we should introduce mass timezone adjust tool in Settings