Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

[FEATURE] Amoled friendly Dark mode #3518

Closed MehrabShawon closed 1 month ago

MehrabShawon commented 2 months ago

Please confirm the following:

What do you want to be added or improved?

As a user I want to request an AMOLED-friendly dark mode. The current dark mode isn't pitch black, and it's uncomfortable for my eyes since I've been using a pitch-black theme for years. It would be great if you could add an AMOLED-friendly dark mode that features a true pitch-black background.

Why do you need it?

How do you imagine it?

I'm looking for an AMOLED dark mode where the background is pitch black instead of gray.

ivywallet commented 2 months ago

Thank you @MehrabShawon for raising Issue #3518! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

paulolima18 commented 2 months ago

Changing the default black in the object IvyColors from this val Black = Color(0xFF09090A) to this val Black = Color(0xFF000000) is enought I think, does this work or maybe we should create a new Theme? @ILIYANGERMANOV

ILIYANGERMANOV commented 2 months ago

We should create a new theme. Otherwise, we'll break our original dark mode that most users like

paulolima18 commented 2 months ago

I'm on it

ivywallet commented 2 months ago

Thank you for your interest @paulolima18! 🎉 Issue #3518 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.