Date picker and time picker color by theme

Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.

https://play.google.com/store/apps/details?id=com.ivy.wallet

GNU General Public License v3.0

2.8k stars 675 forks source link

Date picker and time picker color by theme #3558

Closed oguzsout closed 1 month ago

oguzsout commented 1 month ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

[ ] I've read the Contribution Guidelines and my PR doesn't break the rules.
[ ] I've read and understand the Developer Guidelines.
[ ] I confirm that I've run the code locally and everything works as expected.
[ ] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
[ ] 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Description

Opened this pr on this issue, which is related to the theme problem of date and time pickers.

What's changed?

I've fixed colors of dialogs
I have wrapped it with the proper theme for these colours to work properly

Before	After

Risk factors

...

Does this PR close any GitHub issues? (do not delete)

Closes #3465

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

oguzsout commented 1 month ago

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

ILIYANGERMANOV commented 1 month ago

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

Read this https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md It shouldn't be 200 errors, only errors in the files that you've changed. You can suppress them or if that's too hard add a baseline (the Gradle task might be broken)

shamim-emon commented 1 month ago

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

@oguzsout I can fix the detekt issues if you want.

oguzsout commented 1 month ago

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

Read this https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md It shouldn't be 200 errors, only errors in the files that you've changed. You can suppress them or if that's too hard add a baseline (the Gradle task might be broken)

Yes, I forgot to check here, I will review it again and make the change 🙏

oguzsout commented 1 month ago

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

@oguzsout I can fix the detekt issues if you want.

Thank you very much @shamim-emon , I'm on it now. I'll write to you if I get stuck 🙃

ivywallet commented 1 month ago

⚠️ Hey @oguzsout, this issue is not approved, yet. @ILIYANGERMANOV must approve it first.

Also, make sure to read our Contribution Guidelines.

oguzsout commented 1 month ago

Since the number of lines of the onCreate method exceeds the restriction specified in rule Detekt, I created the setupApp function. I opened and tested the App and it did not cause any problems. @ILIYANGERMANOV @shamim-emon

ILIYANGERMANOV commented 1 month ago

Since the number of lines of the onCreate method exceeds the restriction specified in rule Detekt, I created the setupApp function. I opened and tested the App and it did not cause any problems. @ILIYANGERMANOV @shamim-emon

Sounds good. If the Detekt error is in legacy code, feel free to suppres using an annotation

oguzsout commented 1 month ago

@oguzsout your PR description is missing the section where you have to mention which issue is this PR closing. For reference adding a screenshot below

Actually, I opened this pr for the following issue

shamim-emon commented 1 month ago

@oguzsout your PR description is missing the section where you have to mention which issue is this PR closing. For reference adding a screenshot below

Actually, I opened this pr for the following issue

Yeah and you have to add the issue in PR description like how I had added in provided screenshot.

ILIYANGERMANOV commented 1 month ago

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

ILIYANGERMANOV commented 1 month ago

@oguzsout read the Contribution Guidelines and assign it to yourself

ILIYANGERMANOV commented 1 month ago

To fix the PR description check you need to push a commit unfortunately

oguzsout commented 1 month ago

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

Since that person didn't do it, I wanted to do it, but I couldn't take it upon myself.

ILIYANGERMANOV commented 1 month ago

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

Since that person didn't do it, I wanted to do it, but I couldn't take it upon myself.

In that case, you need to ping me to unassign and then you can take it. We should probably add CI automation for unassigning, as well