Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

[Feature] New Decimal Format Applied In Accounts Tab #3587

Closed shamim-emon closed 1 month ago

shamim-emon commented 1 month ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

6057671498786782891

6057671498786782888

Risk factors

What may go wrong if we merge your PR?

In what cases won't your code work?

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

shamim-emon commented 1 month ago

Didn't review much but we need to fix the format usecase to always say ".00" instead of ".0" on some places because it looks weird and inconsistent. Money formatting is standardized to always 2 decimal places

@ILIYANGERMANOV updated accordingly

suyash01 commented 1 month ago

I see lots of test screen shots missing proper formatting for the total amount shown at the top. To be exact comma(,) is missing from the amount which previously was there. If this was removed intentionally for making space for more digits, I would recommend having a dynamic text size instead of hampering redability.