Ivy-Apps / ivy-wallet

Ivy Wallet is an open-source money manager app for Android, no longer maintained. You can fork the code or download the final version from Google Play.
https://play.google.com/store/apps/details?id=com.ivy.wallet
GNU General Public License v3.0
2.8k stars 675 forks source link

Refactor TransactionCard UI to support compactMode #3623

Closed p42rthicle closed 2 weeks ago

p42rthicle commented 1 month ago

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

Screen recording of your changes (if applicable):

https://github.com/user-attachments/assets/7935fc05-dcc8-4958-a140-28d38f683b27

What's changed?

Describe with a few bullets what's new:

Before After
Old cards video Compact cards video
Old description Updated description

Risk factors

What may go wrong if we merge your PR?

In what cases won't your code work?

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

p42rthicle commented 1 month ago

🚧 WIP Have refactored the TransactionCard to support compactMode

p42rthicle commented 1 month ago

Hi @ILIYANGERMANOV, how do I take care of the failing screenshot test here? :screen:transactions:test - TransactionsPaparazziTest is failing here.

Here is the snapshot of what it expects.

Here, in the empty upcoming transaction card, there is the "deleted" tag that is shown however in my implementation of the compact mode I have omitted tags. Attaching screen recording of current implementation for your reference.

https://github.com/user-attachments/assets/134477a4-191b-426c-b204-633cd68643cb

Can you help me out so I can proceed? Thanks!

p42rthicle commented 3 weeks ago

@ILIYANGERMANOV Could you review this?

ILIYANGERMANOV commented 3 weeks ago

Hey @p42rthicle sorry I missed this PR because the CI was failing and it seemed dangerous to me

p42rthicle commented 3 weeks ago

Yes, I think it's some lint checks that are failing. How do I work on it?

p42rthicle commented 3 weeks ago

I purposely omitted the categories and accounts info as I wanted the compact mode to display just bare minimum information. However, if you suggest I can add those in the compact mode. What do I omit then in that case? Just the #tags and description (and the INCOME/EXPENSE ICON)? The color on the amount text can suggest if it was an income or an expense For transfers, I am showing the transfers Icon and amount and no accounts right now. Do you suggest I add those too and make changes?

p42rthicle commented 3 weeks ago

@ILIYANGERMANOV