Closed p42rthicle closed 2 weeks ago
π§ WIP
Have refactored the TransactionCard
to support compactMode
Hi @ILIYANGERMANOV, how do I take care of the failing screenshot test here?
:screen:transactions:test
- TransactionsPaparazziTest
is failing here.
Here is the snapshot of what it expects.
Here, in the empty upcoming transaction card, there is the "deleted" tag that is shown however in my implementation of the compact mode I have omitted tags. Attaching screen recording of current implementation for your reference.
https://github.com/user-attachments/assets/134477a4-191b-426c-b204-633cd68643cb
Can you help me out so I can proceed? Thanks!
@ILIYANGERMANOV Could you review this?
Hey @p42rthicle sorry I missed this PR because the CI was failing and it seemed dangerous to me
Yes, I think it's some lint checks that are failing. How do I work on it?
I purposely omitted the categories and accounts info as I wanted the compact mode to display just bare minimum information. However, if you suggest I can add those in the compact mode. What do I omit then in that case? Just the #tags and description (and the INCOME/EXPENSE ICON)? The color on the amount text can suggest if it was an income or an expense For transfers, I am showing the transfers Icon and amount and no accounts right now. Do you suggest I add those too and make changes?
@ILIYANGERMANOV
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
https://github.com/user-attachments/assets/7935fc05-dcc8-4958-a140-28d38f683b27
What's changed?
Describe with a few bullets what's new:
TypeAmountCurrency
in the non-compact card is also nowTitleTypeAmountCurrencyRow
just without showing the titlepaidFor
and is ofINCOME
typeRisk factors
What may go wrong if we merge your PR?
compactModeEnabled
was set totrue
income_received
needs to be edited for the two languages (Have added Todo comments)In what cases won't your code work?
Bool Feature
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures β
Pull request checks failing? Read our CI Troubleshooting guide.