Ixam97 / CarStatsViewer

MIT License
99 stars 54 forks source link

Translation: Use Lokalise #121

Open jschlyter opened 1 year ago

jschlyter commented 1 year ago

Per OOB discussion with @Ixam97 I will assist in setting up translation via Lokalise.

It would be most useful if the current translators (ping @DoubleYouEl @robinhellstrom) could sign up via https://app.lokalise.com/public/7279689963f1e922c08f26.64130521/

Edit: New translators must be invited via email - please contact @Ixam97 or @jschlyter.

Ixam97 commented 1 year ago

Also @oddvarr for norwegian translation πŸ˜‰

DoubleYouEl commented 1 year ago

Dutch is translated via Lokalise

oddvarr commented 1 year ago

Norwegian is translated via Lokalise. Easier than here.

Ixam97 commented 1 year ago

I have added the GitHub integration to Lokalise. It will now pull changed and new strings automaticaly and we can create pull requests from within Lokalise.

Also changed Norwegian (no) to Norwegian BokmΓ₯l (nb).

Ixam97 commented 1 year ago

I've added an in-app update notifications containing the changelog. My dev build is now in release candidate state and I would like to release to the master branch tomorrow before being on vacation for a week. A complete translation would be nice for that.

FYI: @jschlyter @DoubleYouEl @oddvarr @blixtdevelopment

oddvarr commented 1 year ago

Norwegian translation up to date :)

blixtdevelopment commented 1 year ago

And Danish translation updated

DoubleYouEl commented 1 year ago

…and Dutch is also up to date

DoubleYouEl commented 1 year ago

(Lokalise is the next best thing after Belgian beer… 😜)

jschlyter commented 1 year ago

πŸ‡ΈπŸ‡ͺ done.

jschlyter commented 1 year ago

At some point, we should try to align some terms between the languages. Most likely not worth it for the change log, but other terms might be. There's support in Lokalise for glossaries, I'll take a look at that.

jschlyter commented 1 year ago

"Optimized driver distraction optimization" :-)

jschlyter commented 1 year ago

Question: Why do we have "Instant consumption" in the display, when we only write "Power" for the current power? In all languages, IMHO it makes more sense to just write "Power" and "Consumption" - since it is changing rapidly it's pretty obvious is not a long term number. WDYT? ping @Ixam97

Ixam97 commented 1 year ago

Just a little heads up: I'm nearing completion for my planned 0.24-Features. I don't think there will be any more strings added in the meantime. There are a few new strings added though. So feel free to have a look.

jschlyter commented 1 year ago

@Ixam97 What about "Consumption" vs "Instant consumption"? Ok to change to simpler wording - saves precious space in the UI?

Ixam97 commented 1 year ago

What about "Consumption" vs "Instant consumption"?

I think I will leave it as is for now. This is a small but significant difference in my opinion. Most people associate consumption with an average andnI want it to be clear this is an instantaneous value.

jschlyter commented 1 year ago

@Ixam97 do you want us to translate the changes notes, or are they to be kept in English only?

Ixam97 commented 1 year ago

do you want us to translate the changes notes, or are they to be kept in English only?

If you do translate them they will be displayed in your language upon fist app start after the update ;)

jschlyter commented 1 year ago

@Ixam97 what about the "SMTP server URL" - do you refer to a SMTP hostname (which is not a URL, but a FQDN I assume)?

Ixam97 commented 1 year ago

what about the "SMTP server URL" - do you refer to a SMTP hostname (which is not a URL, but a FQDN I assume)?

I'm not that into that topic, you are probably right. I will change it to "SMTP hostname".

Ixam97 commented 1 year ago

@jschlyter Do you plan on translating the changes, or are the swedish users going to see english change logs? πŸ˜›

jschlyter commented 1 year ago

@jschlyter Do you plan on translating the changes, or are the swedish users going to see english change logs? πŸ˜›

Fixed now.

Turder84 commented 1 year ago

Finnish is translated, happy if someone wants to review and edit if needed. Tried to check all English reference texts in the app as well to have nature of the translation as much correct as possible.

jschlyter commented 1 year ago

@Turder84 can you find a fellow Finnish speaker in the forum and ask them for review?

Turder84 commented 1 year ago

I'll ask around, I know that few Finnish guys are running the app.

LaurentVitalis commented 1 year ago

I can translate to french. Can you add the language in Lokalise ?

jschlyter commented 1 year ago

I can translate to french. Can you add the language in Lokalise ?

Done @LaurentVitalis!

LaurentVitalis commented 1 year ago

Thanks, i'm on it. I might have to install the app in my car to finetune some strings, to understand the context. French will stay a bit unfinished in Lokalise until then.

EDIT : I'll clone, compile and try in the emulator...

LaurentVitalis commented 1 year ago

I can translate to french. Can you add the language in Lokalise ?

Done @LaurentVitalis!

Can I have the export download files permissions please ? I want to add strings.xml in my values-fr folder to QA my build. Thanks

jschlyter commented 1 year ago

Can I have the ~export~ download files permissions please ? I want to add strings.xml in my values-fr folder to QA my build. Thanks

Fixed. This also means you can edit any language, but please stick for French :-) πŸ‡«πŸ‡·

jkkataja commented 1 year ago

Can anyone add me to the project so I can review the Finnish translation?

jschlyter commented 1 year ago

Can anyone add me to the project so I can review the Finnish translation?

Email me and I'll add you @jkkataja

Turder84 commented 1 year ago

I think the Finnish translation is pretty much done now. Got few okays already and we have done final tweaks based on new suggestions. Maybe some further updates possible when we see language in the app and see if something needs to be edited?

jkkataja commented 1 year ago

I think the Finnish translation is pretty much done now. Got few okays already and we have done final tweaks based on new suggestions. Maybe some further updates possible when we see language in the app and see if something needs to be edited?

Yup, I agree. All the translations should be reviewed now also.

LaurentVitalis commented 1 year ago

French is 99.5% done. There are two last things I want to tweak.

Also, I need to verify something, it looks like POWER and CONSUMPTION are swapped. Consumption being the average kWh/100km, it should stay between 17 and 30 kWh/100km (and not go up to 200+kW). Power is the instant energy draw sucked by the motor(s).

Ixam97 commented 1 year ago

@LaurentVitalis What part exactly do you mean? I'm not aware of any swapped descriptions.

LaurentVitalis commented 1 year ago

@LaurentVitalis What part exactly do you mean? I'm not aware of any swapped descriptions.

False alarm. At first I thought I inverted Power and Consumption because I was surprised by the values. But my localization follows every other languages.

Ixam97 commented 1 year ago

I've added a few strings for 0.24.1. Please have a look at it before release. πŸ‘

jschlyter commented 1 year ago

I've added a few strings for 0.24.1. Please have a look at it before release. πŸ‘

I'm going to try to create a task in Lokalise for this release and see how that works. You can close each language once you are done with it.

jkkataja commented 1 year ago

For the actual translation work the task appeared to work, I got notification of the task and also notification that it was already completed before I had time to have a look at it. What is missing is the review task (which I completed this morning), that might be something to consider if that can be created as a task also? My assumption is of course that translations should be verified.

Ixam97 commented 1 year ago

In case anyone missed it over at Lokalise: I'm planning on releasing 0.25 really soon. So it would be nice to have all translations done within the next few days.

Also remember to have a look at the key dialog_reset_message since this has changed since 0.24.

Thank you!

DoubleYouEl commented 1 year ago

In case anyone missed it over at Lokalise: I'm planning on releasing 0.25 really soon. So it would be nice to have all translations done within the next few days.

Also remember to have a look at the key dialog_reset_message since this has changed since 0.24.

Thanks for the headsup - I just finished the Dutch translation - I hope you can still include it in the final release.

jschlyter commented 1 year ago

Swedish should be ready, although the tasks still says I have 208 words to translate.

LaurentVitalis commented 1 year ago

French done.

Ixam97 commented 1 year ago

@jschlyter My guess is that this is due to you not being an assignee to that language.

ivanfmartinez commented 1 year ago

@Ixam97 I can work to make an pt_BR version, I just don't have an environment to build and put the app on our Volvo, I'm waiting for new slots for testing.

DoubleYouEl commented 1 year ago

@Ixam97 I can work to make an pt_BR version, I just don't have an environment to build and put the app on our Volvo, I'm waiting for new slots for testing.

For translation, no build environment is required. We use Lokalise, a web-based platform for translation (localization) - independently from the actual software building process

ivanfmartinez commented 1 year ago

@Ixam97 I can work to make an pt_BR version, I just don't have an environment to build and put the app on our Volvo, I'm waiting for new slots for testing.

For translation, no build environment is required. We use Lokalise, a web-based platform for translation (localization) - independently from the actual software building process

I know that, but sometimes is better when you see the message in the real context to use correct words, and also check if the size fits.

ivanfmartinez commented 1 year ago

Brazilian Portuguese translation is done, now that I have app installed thanks to the procedures in #185 and @Ixam97 created the language on Lokalise

Ixam97 commented 10 months ago

@jschlyter Do you think you can finish the Swedish translation within the next few days? I would like to have it as complete as possible for the next update.