search

IxorTalk / ixortalk.aws.cognito.jwt.security.filter

Spring Boot security filter for decoding Cognito JWT IdTokens
MIT License
88 stars 31 forks source link

Duplicate #5

Closed ronesim closed 6 years ago

ronesim commented 6 years ago

I was looking through the code and I found out that classes: AwsCognitoAutoConfiguration, AwsCognitoCredentialsHolder, AwsCognitoJtwConfiguration, JwtAuthenticationProvider are not used. Moreover JwtAutoConfiguration, JwtConfiguration and JwtIdTokenCredentialsHolder are doing the same thing. Can you clarify me this thing please? Am I missing something?

aurelienmarie commented 6 years ago

+1

Some classes look exactly the same. The purpose of the classes aren't well documented.

aurelienmarie commented 6 years ago

I've personally removed all the "AWSCognito". Kept only the "JWT" classes and still works. Also i've added some Lombok annotations to make code clearer. Works like a charm, Thank you IxorTalk.