search

Iyengar111 / NanoLog

Low Latency C++11 Logging Library
727 stars 186 forks source link

Integration with a crash handling library #18

Open t-artikov opened 7 years ago

t-artikov commented 7 years ago

NanoLog does not contain crash handling code. I think this is the right decision, as it is the task of a crash handling library. But it would be nice if NanoLog had a function that can be called when a crash happened to be sure that all log messages were written. Something like:

CrashHandling::setCrashCallback([] {
    nanolog::flush();
});
Iyengar111 commented 7 years ago

Hi,

Sorry for the extremely delayed reply. I don't seem to be getting emails about new updates on this repository!!.

I like your idea. If you don't mind and have the time, could you raise a pull request and I will review and merge it.

If not, I'll pick it up sometime when I get the inspiration :)

Thanks,

Karthik Iyengar

t-artikov commented 7 years ago

Hi, I'm afraid I will not implement it properly by myself. But I'll be glad to try NanoLog as a logging library if it has this feature.