search

IyesGames / iyes_loopless

Alternatives to Bevy States, FixedTimestep, Run Criteria, that do not use "stage looping" and are composable
Other
249 stars 27 forks source link

migrate some bevy changes #17

Closed bayou-brogrammer closed 2 years ago

bayou-brogrammer commented 2 years ago
  1. Bevy time is now exported from bevy_time package https://github.com/bevyengine/bevy/commit/644bd5dbc6c281a4fae65c603f09b6666de8c566
  2. Bevy removed Ortho camera and UI Camera. The 3d/2d cameras now handle UI elements https://github.com/bevyengine/bevy/pull/4745
  3. bevy::input::system::exit_on_esc_system is now bevy::window::close_on_esc
  4. Rect is now UIRect for UI Elements
  5. as_system_label is now not needed. (Screenshot taken from bevy source) CleanShot 2022-06-14 at 13 57 27@2x
inodentry commented 2 years ago

Most of your changes are formatting changes. I'm guessing you either ran cargo fmt or your editor has auto-formatting. Could you please not do that? It makes it very hard to see what the commit actually changes.

I am personally not a fan of enforcing rustfmt autoformatting in my projects. I would rather everyone just commit things with some sensible (even if inconsistent) formatting in the first place, and avoid the noise/spam of the autoformatter.

bayou-brogrammer commented 2 years ago

Ah yeah I can fix it and try again. Pretty sure my vscode runs it automatically