IzK-ArcOS / ArcOS-API-Rewritten

Rewrite of the old backend API
GNU General Public License v3.0
5 stars 6 forks source link

Missing dependency? #9

Closed NikNikovsky closed 1 year ago

NikNikovsky commented 1 year ago

I really am guessing here, not expecting this to be merged

Spaceginner commented 1 year ago

the issue with libmagic only happens on windows (due to windows being very good™, it doesnt have libmagic binary), so the actual change should have been adding

python-magic-bin; sys.platform == 'win32'
Spaceginner commented 1 year ago

ALSO, py is a windows-only thing as well (due to, again, windows being very good™)

NikNikovsky commented 1 year ago

I will just add a new line then

Spaceginner commented 1 year ago

I will just add a new line then

hm?

NikNikovsky commented 1 year ago

that ok?

Spaceginner commented 1 year ago

that ok?

no, because python3 works on windows as well, i was talking about the change you made python -m venv venv -> py -m venv venv

py is windows-only (and it was introduced due to crappiest handling of PATH in windows)

NikNikovsky commented 1 year ago

alright, that ok?

Spaceginner commented 1 year ago

yeee

eversiege commented 1 year ago

TODO: write proper readme for backend, should consult DWC before starting work on documentation about backend