search

Izib / rfc5766-turn-server

Automatically exported from code.google.com/p/rfc5766-turn-server
0 stars 0 forks source link

Create permission handling is not atomic #97

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If a create permission message is sent and some of the addresses fail (wrong 
address family, forbidden destination, etc.), permissions for addresses listed 
earlier in the request are installed despite the error response.

What steps will reproduce the problem?
1. Start the turn server forbidding some peer addresses.
2. Send a CREATE-PERMISSION message with one allowed peer address followed by a 
forbidden peer addrss.
3. Note the 403 response to CREATE-PERMISSION. 
4. Send a packet from the allowed peer address.

What is the expected output? What do you see instead?
Packet should not be routed (since CREATE-PERMISSION failed).  Instead it is 
allowed.

What version of the product are you using? On what operating system?
Current trunk.

Please provide any additional information below.
I confess to diagnosing this problem from code inspection, not actually testing 
it.

Original issue reported on code.google.com by jonathan...@gmail.com on 7 Feb 2014 at 11:27

GoogleCodeExporter commented 9 years ago

Original comment by mom040...@gmail.com on 8 Feb 2014 at 12:29

GoogleCodeExporter commented 9 years ago 
The issue is fixed in SVN, will be a part of 3.2.2.6 build.

Original comment by mom040...@gmail.com on 8 Feb 2014 at 1:25

GoogleCodeExporter commented 9 years ago 
Fixed in 3.2.2.6

Original comment by mom040...@gmail.com on 9 Feb 2014 at 7:22