IzzelAliz / Arclight

A Bukkit(1.19/1.20) server implementation in modding environment using Mixin. ⚡
GNU General Public License v3.0
1.43k stars 212 forks source link

Arclight incompatibility with direct ByteBuf writing #1305

Open ShadowOfHeaven-Me opened 2 months ago

ShadowOfHeaven-Me commented 2 months ago

I have confirmed that ...

Arclight version

arclight-1.16.5-1.0.25-7cf92be3

OS & Java versions

Windows & 1.8

Plugins and Mods

AlixSystem, my own plugin, where I directly create and send ByteBufs, but I don't do the compression, but instead write it to the handler which does.

Description

Players that try to join disconnect automatically as they receive an invalid packet. The error is like this: DecoderException: ArrayIndexOutOfBounds, with no additional information, so I suspect maybe an invalid packet id? Pretty sure that'd give a more detailed feedback (since it uses a List), but who knows.

Step to reproduce

  1. Create a spigot server on offline mode.
  2. Add my plugin (found here)
  3. Join the server

Logs

Only this, which does not appear if the plugin is absent (or so I was told) (it should be noted that I do not modify the advancements in any way nor do I spoof them)

Using new advancement loading for net.minecraft.advancements.PlayeAdvancements@3c231da7

Server pack link (Optional)

No response