search

Izzimach / react-three-legacy

React bindings to create and control a 3D scene using three.js
Other
1.52k stars 127 forks source link

Incompatible with React 16 #108

Open danyim opened 7 years ago

danyim commented 7 years ago

I am getting the following error when attempting to use this library in my React 16 project: Module not found: Can't resolve 'react-dom/lib/ReactCompositeComponent'

Does this project share the same technical reason why react-three-renderer can't support v16? https://github.com/toxicFork/react-three-renderer/issues/197

Izzimach commented 7 years ago

Yeah, the rewrite of React for v16 changed a lot of internals. I don't have the free time I once did so the rewrite will be a long time coming. I should update the README.

eeh commented 6 years ago

I had a reason to upgrade to React 16, and ran of course in to the above problem.

Any update? Anything I can do to help?

danyim commented 6 years ago

@eeh Rewrite the codebase to use Fiber :P But seriously, what would be best is to contribute to react-three-renderer as they're farther along in getting it implemented than this project.

Izzimach commented 6 years ago

Yeah, R3R is pretty similar to react-three so you should be able to switch over and it looks like they are actively moving toward getting React 16 to work.

wayofthefuture commented 5 years ago

Can anyone recommend react-three-fiber versus react-three-renderer?