search

Izzimach / react-three-legacy

React bindings to create and control a 3D scene using three.js
Other
1.52k stars 128 forks source link

commonjs config incorrect? #46

Closed gilbox closed 8 years ago

gilbox commented 8 years ago

It's possible I just don't understand how commonjs works, but it looks like the configuration in dev branch is not correct. The output file react-three-commonjs.js contains libs other than react-three.

I have about a dozen public npm packages and none of them are distributed with sub-dependencies like this so it doesn't really make sense to me to do it this way.

Izzimach commented 8 years ago

I haven't actually published the stuff in dev so it's likely broken, yeah. But the webpack config for commonjs specifies React and THREE as externals so they shouldn't get included. Or are you referring to some other dependency? I probably threw lodash in there without thinking about it.

gilbox commented 8 years ago

honestly i don't know anymore. possibly i was just tired and confused. will check it out again and let you know if I see any issues.

gilbox commented 8 years ago

sorry about this. i was totally wrong. all is well.