readme says pointerEvents is property for the Renderer, but pointerEvents are for Scene

Izzimach / react-three-legacy

React bindings to create and control a 3D scene using three.js

Other

1.52k stars 128 forks source link

readme says pointerEvents is property for the Renderer, but pointerEvents are for Scene #88

Closed macrozone closed 7 years ago

macrozone commented 7 years ago

Some confusion in the readme here: https://github.com/Izzimach/react-three/blob/1d446545cbeb44993e515dc45fd02e4d0193986d/README.md#extra-props

pointerEvents should be defined on the <Scene /> not on the <Renderer />. Example "interactive" uses it correctly.

should i do a PR?

Izzimach commented 7 years ago

Oops, at some point the <Renderer> and <Scene> components got a major rework and this was probably missed. If you want to make a PR to update the docs that would be great.