Added support for specifying matrix transformations directly

Izzimach / react-three-legacy

React bindings to create and control a 3D scene using three.js

Other

1.52k stars 128 forks source link

Added support for specifying matrix transformations directly #94

Closed slindberg closed 7 years ago

slindberg commented 7 years ago

This PR adds support for specifying a local transformation matrix via the matrix prop. If specified, position, quaternion, rotation, and scale properties are ignored. This also fixes the issue of the quaternion property being ignored, as described in #93.

Izzimach commented 7 years ago

I was going to mention checking that someone doesn't specify both a matrix and some other prop, but you already did that!

Izzimach commented 7 years ago

Am I correct in assuming this includes the fix made in #93? It looks like the same checks are in there.

slindberg commented 7 years ago

Yes, it fixes the same issue as #93, closing that one now. Thanks!