Added optional automated confirmation for backups

IzzySoft / Adebar

Android DEvice Backup And Report, using Bash and ADB. Moved to https://codeberg.org/izzy/Adebar -- this is only a mirror now.

GNU General Public License v2.0

246 stars 41 forks source link

Added optional automated confirmation for backups #12

Closed inktrap closed 9 years ago

inktrap commented 9 years ago

I implemented optional automated confirmation for backups.
Adebar's backup function wil be running in the background, so confirmation keycodes can be sent.
I tested the script-generation and the resulting script and they both work.
Also I tried to follow the Adebar coding-style, if you have any suggestions, tell me
I think this ability is very important and adds greatly to the usability of Adebar

inktrap commented 9 years ago

Also I updated the config in my branch with a note that spaces are currently not supported in passwords, but this is not included in this PR. So feel free to add it.

Btw.: Making spaces work would require to split the password, then enter each segment, then the space via keyevent 62. (This won't work, see comment below)

inktrap commented 9 years ago

1) I tried implementing the fix for spaces in passwords and entering them works. But if there are more than two spaces, the keyboard will be visible and the following keycodes fail.

2) I also tried including spaces inline "like%sthis", which is much nicer than 1) but that gave the same results. Therefore I won't be implementing this. No spaces for backup-passwords, keycodes are to fragile.

IzzySoft commented 9 years ago

Thanks a lot! This sounds good – an on a quick investigation also looks good, so I will merge this PR. It requires an additional change, though: As using a config file is optional, defaults for the two new settings need to be placed in adebar_cli as well. Until approved by more devices/users, I'll put AUTO_CONFIRM=0 there for now.

Speaking of which: May I ask you to add your device details to issue #7?

IzzySoft commented 9 years ago

PS: Any plans to support this with the restore scripts as well?

inktrap commented 9 years ago

re: restore scripts: sure, why not? Haven't looked at them yet and have not tried restoring at all.

Excerpts from Izzy's message of 2015-11-08 15:18:08 +0100:

PS: Any plans to support this with the restore scripts as well?

Reply to this email directly or view it on GitHub: https://github.com/IzzySoft/Adebar/pull/12#issuecomment-154829201

IzzySoft commented 9 years ago

Thanks in advance! No need to "hurry" – whenever you find time is fine. Before compiling this into a new "release", I just think it should be "complete" :)