search

IzzySoft / Adebar

Android DEvice Backup And Report, using Bash and ADB. Moved to https://codeberg.org/izzy/Adebar -- this is only a mirror now.
GNU General Public License v2.0
246 stars 41 forks source link

Devices via TCP/IP not recognized and fix for ADB mess up #15

Closed chaotix- closed 8 years ago

chaotix- commented 8 years ago

Both fixes are not related. (The ADB mess up explained in the patch also happens via direct USB connection.)

If you want, I can create seperate pull requests, but as the changes are so minor I thought it would be easier this way.

IzzySoft commented 8 years ago

I'd merge the regexp one happily, but would prefer solving the other slightly different (see note there). As I see no way to cherry-pick the one I'd accept (at least not via this web gui), I'd accept your offer to create separate PRs (always the better idea ;)

chaotix- commented 8 years ago

I thought it would be cleaner directly in the bash function. Yes for running the script it makes no difference, but somebody may just want to source the functions so s/he can call them directly from the shell.

Also it might be more confusing as the backup scripts need to be called from the base directory (because they create the "userApps" subdirectory) but then the functions defined in these scripts would need to be called in the subdirectory.

But I don't feel strongly either way. These are just the reasons why I decided to do it the way I did. I you feel otherwise, I can move the 'cd'.

IzzySoft commented 8 years ago

OK, I've cherry-picked the serial one, and implemented the other one as described. Please test if it works this way :)

PS: As for your other concern, the restore scripts are modified the same way.