search

IzzySoft / Adebar

Android DEvice Backup And Report, using Bash and ADB. Moved to https://codeberg.org/izzy/Adebar -- this is only a mirror now.
GNU General Public License v2.0
246 stars 41 forks source link

MobaXterm compatibility #23

Closed JimboJoe closed 7 years ago

JimboJoe commented 7 years ago

Hello,

I needed to have Adebar work under Windows, so I used MobaXterm. It didn't work out-of-the-box, I had to make some small changes in order to make it work:

You'll find the patch here: Adebar-MobaXterm-Windows.patch.txt Here is my hoping to end-up with a unified version, compatible with every platform. Thanks anyway !

IzzySoft commented 7 years ago

Thanks Jimbo – that looks good! I just verified results match with egrep vs. grep -E on Linux. I could re-check on MobaXterm on Monday (I use that at work where I'm forced to Windows, so I have an environment I know how to deal with) – but I trust it will do; after all it does for you :)

To give credits where credits are due: Maybe you want to fork Adebar, apply the changes to your clone, and submit them as pull request – so they are associated with you, and you turn up here as "contributor"?

JimboJoe commented 7 years ago

I was mostly concerned by the regexp changes, as I can't test them on Linux (and still can't explain why "$" or "\s" have a different behavior!). I made a proper PR (#24).

IzzySoft commented 7 years ago

Thanks, I'll check that.

Must have missed the regex changes on my "quick glance". They might cause misbehavior, especially if a device ID contains a dot or colon, and is separated from the term "device" by spaces instead of a tab – or some error message matches that. The line end mark was omitted, so there could be something like 012.34:5ABC device has issues, which would be skipped by the original regex but matched by yours.

What made you change that regex? Can you provide me with the output of adb devices on your end? I could then try finding a better solution, and could even test that on MobaXterm on Monday.

IzzySoft commented 7 years ago

Thanks again for your contribution! Closing this issue now as it has been solved by your PR #24 :+1: