J-D-K / JKSV

JK's Save Manager Switch Edition
GNU General Public License v3.0
1.35k stars 99 forks source link

Nuclear Blaze makes the app crash #217

Open ciucciodifuoco opened 10 months ago

ciucciodifuoco commented 10 months ago

Hey,

Switch Lite 17.0.0 + atmosphere 1.6.2 + hekate 6.0.7

i'm playing this game lately: https://www.nintendo.com/us/store/products/nuclear-blaze-switch/ when i do a backup (in full app mode, launching a game with R button pressed) for this game in JKSV crashes with the error "The software closed unexpectedly" . If i do the same in Applet mode, the whole atmosphere crashes and console must be rebooted.

The bug is easily triggerable, just do a bakcup for Nuclear Blaze

fennectech commented 10 months ago

Possible that it has files with foreign characters in the save archive? Can you open nuclear blaze in the file mode of JKSV?

J-D-K commented 10 months ago

As stated above, check the file names to see if they're all ASCII characters. See if using or ending the save name with .zip helps at all.

ciucciodifuoco commented 9 months ago

Hi guys, sorry for the late reply. I can open the game in File mode , find attached some screenshots. Where should i actually verify the presence fo non-ascii charachters?

IMG_2680 IMG_2679

J-D-K commented 9 months ago

There are none as far as I can see. The one thing that is interesting is the path on the bottom left. sv:/ /. It's something I'd need to investigate.

J-D-K commented 1 month ago

I've just had it confirmed to me that these kind of games only work with ZIP files. Some games use UTF8 filenames and for some reason, even though the paths work in save containers, they don't work with the SD card... Nice one Nintendo.

impeeza commented 1 month ago

I just «buy» the game for this issue and found: The savegame of that tile IS INSIDE A FOLDER (DIRECTORY) WITH the name « » yes, a space character (0x20), When you select the user and then the title, using the (X) menu «Title Optons» and selecting Open in File Mode:

image

you find the folders «.», «..» and «D» image

Then the savegame files are INSIDE the «space name» folder: image

You can copy the files from that folder to any other folder on your SD, but JKSV have trouble creating a new backup because first have to create a « » folder on SD:/JKSV/Nuclear Blaze/USER - YYYY.MM.DD @ HH.MM.SS" folder. I doubt the Fat32 allow you to create that no-name folder and that's why the software crashes.

image image

impeeza commented 1 month ago

And yes setting saves to zip file works because zip file allows you to create a " " folder

image

image

J-D-K commented 1 month ago

I noticed that earlier too @impeeza. Really odd choice to be honest. The only purpose I can see for it is preventing homebrew save backups. Unfortunately JKSV has to support both for backwards compatibility with older versions and other tools that followed the JKSM 3DS backup style/structure. I can think of ways to check for it, but for only one game, that seems like a lot of effort…

impeeza commented 1 month ago

I don't know if worth for something the bin of the Rewrite branch not only crash trying to make this backup but all atmosphere crash.

impeeza commented 1 month ago

I noticed that earlier too @impeeza. Really odd choice to be honest. The only purpose I can see for it is preventing homebrew save backups. Unfortunately JKSV has to support both for backwards compatibility with older versions and other tools that followed the JKSM 3DS backup style/structure. I can think of ways to check for it, but for only one game, that seems like a lot of effort…

Was I thinking what this is a unintended error on the game code is a space on a line of the original code. this is bizarre.