search

J-D-K / JKSV

JK's Save Manager Switch Edition
GNU General Public License v3.0
1.37k stars 101 forks source link

Fix empty [R] name on certain webdav servers. #234

Closed rado0x54 closed 1 month ago

rado0x54 commented 2 months ago

Fixes #227 

commit 045ae7024e1c4dd1f5e6f80d08e39dab33b1fcb6 (HEAD -> bugfix/fix-no-itemname, origin/bugfix/fix-no-itemname)
Author: Martin Riedel <1713643+rado0x54@users.noreply.github.com>
Date:   Thu Jul 25 18:20:08 2024 -0400

    fix: Provide fallback for item.name from href if webdav server does not provide "displayname" property.
impeeza commented 2 months ago

Excellent I just build the latest Main with you PR applied and works fine with a Apache 2.4.55 on windows!!

Sadly the problem with some games which their name have invalid characters, still no avail to create backup via WebDav, by example the game "Princess Peach: Showtime!" have ":" on their name, normal local JKSV backup creates the folder "Princess Peach Showtime!" replacing the invalid character by a space " ", but the WevDav process do not make this translation so the backup try to create the file: "PUT /Entrada/JKSV/Princess%20Peach%3A%20Showtime%21/Impeeza%20-%202024.07.12%20%40%2022.49.50.zip" ("PUT/Entrada/JKSV/Princess Peach: Showtime!/Impeeza - 2024.07.12 @ 22.49.50.zip" so Apache do not create the folder therefore no backup can be transmitted.

So many Switch games have a ":" on their names!!!

impeeza commented 2 months ago

By the way, Thanks a lot for this work!

rado0x54 commented 2 months ago

Sadly the problem with some games which their name have invalid characters, still no avail to create backup via WebDav, by example the game "Princess Peach: Showtime!" have ":" on their name, normal local JKSV backup creates the folder "Princess Peach Showtime!" replacing the invalid character by a space " ", but the WevDav process do not make this translation so the backup try to create the file: "PUT /Entrada/JKSV/Princess%20Peach%3A%20Showtime%21/Impeeza%20-%202024.07.12%20%40%2022.49.50.zip" ("PUT/Entrada/JKSV/Princess Peach: Showtime!/Impeeza - 2024.07.12 @ 22.49.50.zip" so Apache do not create the folder therefore no backup can be transmitted.

So many Switch games have a ":" on their names!!!

Can you create a dedicated issue for that? Than it's easier to track and I can take a look.

impeeza commented 2 months ago

created the issue https://github.com/J-D-K/JKSV/issues/235

320x200 commented 1 month ago

Thank you so so much @rado0x54 for this fix! Works like a charm on the new binary released by @J-D-K (thanks!) a few hours ago :)