search

J-D-K / JKSV

JK's Save Manager Switch Edition
GNU General Public License v3.0
1.42k stars 104 forks source link

`autoUpload` is ignored (because it's not listed in `cfgStrings`) #243

Open imax9000 opened 2 months ago

imax9000 commented 2 months ago

https://github.com/J-D-K/JKSV/blob/master/src/cfg.cpp#L23

(also, please refactor it to have the list of options in only one place. E.g., by storing lambdas or pointers to member in the map)

jgavrus commented 1 month ago

hello @J-D-K, thank you for this great app. Did you look to this issue? now, unfortunately, auto-upload doesn't work, for now, it can be very helpful when using "dump all" option. with a combination of these 2 features we can create a dump for all saves and send it to the cloud using 1 button

impeeza commented 1 month ago

hello @J-D-K, thank you for this great app. Did you look to this issue? now, unfortunately, auto-upload doesn't work, for now, it can be very helpful when using "dump all" option. with a combination of these 2 features we can create a dump for all saves and send it to the cloud using 1 button

Please read the others issues, in special: https://github.com/J-D-K/JKSV/issues/242#issuecomment-2308393177

J-D-K commented 1 month ago

Sorry about this. I added the config string at some point and had to fix a bug and forgot about it when I pushed the fix if I remember correctly. Auto upload was only implemented in a build I had a couple of years ago and I don't have it anymore for whatever reason. The master branch is getting one final update to use FsLib to hopefully fix one last bug and then I'm moving on to the Rewrite for sure because the code is cleaner and easier to maintain. It's on the list of stuff I never got to finish or wanted to clean up.

J-D-K commented 3 weeks ago

Small update. It looks like the master branch might not be getting an update and that bug that was reported to me might be complete bull somebody made up because myself and two other people can't duplicate the results and it seems to work completely fine as-is. Unless someone else can show me JKSV not working correctly with that boring whale Selfloss game, I'm moving on to the rewrite 100%.

J-D-K commented 2 weeks ago

This is going to be tackled in the rewrite guys. I hope it won't take too long. Navigating the master branch's code is a headache for me. I know it's my own fault, but even just adding some recent changes took more time than it should have.