J-Lentz / iwgtk

Lightweight wireless networking GUI (front-end for iwd)
GNU General Public License v3.0
217 stars 15 forks source link

tray icon not working on breeze icon theme on KDE with latest master #30

Closed henning-schild closed 2 years ago

henning-schild commented 2 years ago

27 did fix the in-app icons but the system tray icon still looks wrong

henning-schild commented 2 years ago
$ iwgtk -i
Icon theme 'breeze' is missing icon 'network-wireless-signal-excellent-symbolic': Overriding theme to Adwaita

but in the tray i just see an empty gap with f48e7c2c3b55a32e50be061a96bc809be8b4e284

henning-schild commented 2 years ago

maybe the whole tray thing is happening before that override kicks in, and it needs to be updated after the override has been applied

henning-schild commented 2 years ago

if i trigger a round of "disconnect" "connect" i get an icon ... but it will stay on one that looks very disconnected even though it is connected

J-Lentz commented 2 years ago

What version of iwd are you using?

henning-schild commented 2 years ago

1.27

J-Lentz commented 2 years ago

Ah, that's the problem. The indicator icon in station mode depends on recent changes made to iwd's SignalLevelAgent API, and therefore only works properly with iwd >=1.28.

henning-schild commented 2 years ago

let me try 1.28, so 0.6 needs >=1.28? or will 0.6+ introduce that?

henning-schild commented 2 years ago

yes! 1.28 fixes the problem. I now wonder if i should also make 0.6 depend on >=1.28 in gentoo

J-Lentz commented 2 years ago

iwgtk 0.5 was actually the first release to depend on iwd >=1.28. I'd recommend making >=1.28 a dependency, since otherwise the indicator icon doesn't work as expected.

henning-schild commented 2 years ago

ok cool, will do that!

henning-schild commented 2 years ago

https://github.com/gentoo/gentoo/pull/26170

J-Lentz commented 2 years ago

Great, thanks. I'll plan to make a 0.7 release shortly, since #27 probably affects a significant number of users on other distros as well.