search

J-PAL / PII-Scan

R code to scan for obvious PII.
MIT License
15 stars 8 forks source link

Add support for generic CSV files #12

Closed umeditor closed 7 years ago

umeditor commented 7 years ago

Scan files with ".csv" extension.

rchayes13 commented 7 years ago

I just added my update to the code that scans CSVs. I'm not sure I added it correctly. Let me know if you have questions.

In order to prevent the PII_output.csv code from being scanned during the CSV scanning part, I modified the path references. So now the output writes to the working directory and the user needs to specify a data path below the working directory.

umeditor commented 7 years ago

Thanks for the quick commit. I'm going to make a few small tweeks. In the future, create a branch that we can review and create a pull request from instead of committing directly to master. That will help make sure that master works while we work on new features and fixes in branches.

rchayes13 commented 7 years ago

Sorry, I meant to create a branch but didn't realize that I was writing to the master. Do I need to create a branch in my local repository before I start working on the code? Or is it possible to make a branch after I've made some changes?

umeditor commented 7 years ago

If you've not committed your changes, you can create a branch at any point using git checkout -b [new-branch] where [new-branch] is the name of the branch. My general work flow when starting a new feature or working on a bug are:

  1. git pull to get current code from GitHub
  2. git checkout -b [new-branch] to create a new branch and switch to it
  3. Make changes
  4. If necessary, git add . to add any new files to git
  5. git commit -a -m "commit message" to commit changes to branch
  6. git push -u origin [new-branch] to push branch to GitHub and track future changes to it (future git pull from the local machine will get changes to the branch found on GitHub
  7. Make a pull request on GitHub and ask for a review
  8. Merge pull request via GitHub after any necessary changes
rchayes13 commented 7 years ago

Ok thanks, that's very helpful.