search

J-Rios / TLG_JoinCaptchaBot

Telegram Bot to verify if users joining a group are human. The Bot sends an image captcha for each new user and kicks any of them who can't solve the captcha in a specified time.
GNU General Public License v3.0
520 stars 217 forks source link

[Request] Configurable deletion of welcome messages #13

Closed marcopaganini closed 4 years ago

marcopaganini commented 4 years ago

The captcha message is correctly being deleted, but the "Welcome" message that is sent after the confirmation succeeds is not. Looking at the source (http://bit.ly/2YICmuf) it appears that there's a call to tlg_send_selfdestruct_msg() to do this, but it's commented out. This should be an option, hidden behind configuration.

J-Rios commented 4 years ago

Sure, we could create a new command to configure this and a new chat parameter to store this persistent config in each chat json file (like we do with chat language or chat captha captcha difficult level).

I'm open for PR about this, there is a lot of things that can be configurable and a lot of new functionalities that can be done, however I can't spent time in everything ;)

AndydeCleyre commented 4 years ago

This seems to be working fine, here's a screenshot from the audit log:

image

J-Rios commented 4 years ago

Thanks @AndydeCleyre.

After some time, the captcha completion message behavior has been changed to be self-deleted by default too, so this issue title about "message not being removed" has lost the sense...

The issue could persist regarding to a request of make remove captcha completion message behavior configurable by users, however due it was open for long as half of year without receiving a PR, I'm going to close it now, if anyone really needs that this become configurable, feel free to open it again...

Regards.