search

J-Rios / TLG_JoinCaptchaBot

Telegram Bot to verify if users joining a group are human. The Bot sends an image captcha for each new user and kicks any of them who can't solve the captcha in a specified time.
GNU General Public License v3.0
515 stars 217 forks source link

Add Finnish localization #152

Closed Mikaela closed 2 years ago

Mikaela commented 2 years ago

Will I need to escape {ä,ö,å} and do you have any recommendation on ensuring string validity? I am working in codium --diff en.json fi.json.

I am not used to translating json files directly and have concerns on keeping them up-to-date, while generally projects I contribute to through translations use Weblate or GNU/Gettext which I translated through PoEdit.

J-Rios commented 2 years ago

Hi,

For checking if the JSON file is valid, there is a python script in source directory that you can run:

cd TLG_JoinCaptchaBot/sources
python3 langcheck.py

Maybe I should add some GitHub action workflow to run that script automatically on CI when a Pull Request is received...

J-Rios commented 2 years ago

I'm not sure if that characters need to be escaped, but if you run the langcheck script and see that it is needed, just add a back-slash character before any of them: "ATTR" : "Ex\ämple text f\ôr char\åcters"

Mikaela commented 2 years ago

I had errornesously added new lines to the beginning, but now python3 langcheck.py passes and everything should be translated. Do you have an option to squashwith GitHub or should I squash the commits locally?

J-Rios commented 2 years ago

No problem, GitHub allows to select the merge procedure to apply, "Merge Commit", "Squash Merge" or "Rebase Merge", so I will merge squashing into a single commit.

One last thing, is ok if I put your name (or username) into language contributors list in the Readme file?

Mikaela commented 2 years ago

One last thing, is ok if I put your name (or username) into language contributors list in the Readme file?

I guess so, probably as Aminda Suomalainen (@Mikaela), judging by the other entries

Mikaela commented 2 years ago

unless they are Telegram usernames in which case I am https://t.me/AmindaEU