J-Rios / TLG_JoinCaptchaBot

Telegram Bot to verify if users joining a group are human. The Bot sends an image captcha for each new user and kicks any of them who can't solve the captcha in a specified time.
GNU General Public License v3.0
532 stars 218 forks source link

[Request] LANG_CHANGE message modification suggestion #93

Closed dakeshi closed 3 years ago

dakeshi commented 3 years ago

in language file,

"LANG_CHANGE": "Language changed to English.",

With this constant message structure, a bot tells us misleading result when we configure it with other lang.

expected result

Language changed to {target_lang}

current result

Language changed to English

J-Rios commented 3 years ago

Context

Currently, the word English of "LANG_CHANGE" text must be translated to current language file when texts are translated.

Example: when making Korean translation, the word English should be translated to Korean in Korean language...

Possible Fixs

To avoid mistakes when translation is done, this can be done:

J-Rios commented 3 years ago

Maybe we should go with option B, it is the more simple and avoid any future problems regarding language names (also avoid the needs to add and maintain a "language code - language name" correspondence in constants.

dakeshi commented 3 years ago

agree. option B looks the most simple solution

J-Rios commented 3 years ago

Ok, done in this commit, just changed in english file for future translations and fixed in Korean.