J-Tanzanite / Little-Anti-Cheat

Anti-Cheat for Source Games
286 stars 69 forks source link

Enabling sourcebans+ break bans #130

Closed lunatixxx closed 2 years ago

lunatixxx commented 2 years ago

Did not have any problem before. Pretty sure it is trying to translate the ban reason from message "[SM] Player was banned by console (reason: ---)" to everyone on the server in chat and that is the reason it breaks.

L 08/11/2022 - 04:28:11: [SM] Exception reported: Translation failed: invalid client index 1601069410 (arg 6) L 08/11/2022 - 04:28:11: [SM] Blaming: lilac.smx L 08/11/2022 - 04:28:11: [SM] Call stack trace: L 08/11/2022 - 04:28:11: [SM] [0] Format L 08/11/2022 - 04:28:11: [SM] [1] Line 211, extra/lilac_stock.sp::lilac_ban_client L 08/11/2022 - 04:28:11: [SM] [2] Line 339, extra/lilac_aimbot.sp::lilac_detected_aimbot L 08/11/2022 - 04:28:11: [SM] [3] Line 282, extra/lilac_aimbot.sp::timer_check_aimbot

L 08/11/2022 - 04:17:47: [SM] Exception reported: Translation failed: invalid client index 1601069410 (arg 6) L 08/11/2022 - 04:17:47: [SM] Blaming: lilac.smx L 08/11/2022 - 04:17:47: [SM] Call stack trace: L 08/11/2022 - 04:17:47: [SM] [0] Format L 08/11/2022 - 04:17:47: [SM] [1] Line 209, extra/lilac_stock.sp::lilac_ban_client L 08/11/2022 - 04:17:47: [SM] [2] Line 150, extra/lilac_bhop.sp::lilac_ban_bhop L 08/11/2022 - 04:17:47: [SM] [3] Line 78, extra/lilac_bhop.sp::check_bhop_max L 08/11/2022 - 04:17:47: [SM] [4] Line 50, extra/lilac_bhop.sp::lilac_bhop_check L 08/11/2022 - 04:17:47: [SM] [5] Line 348, plugin.sp::OnPlayerRunCmd

lunatixxx commented 2 years ago

// Ban reason language. // 0 = Use server's language. // 1 = Use the language of the cheater. // - // Default: "1" // Minimum: "0.000000" // Maximum: "1.000000" lilac_ban_language "1"

azalty commented 2 years ago

What version are you running? Try updating.

SB++ doesn't seem to be the reason of the bug, it's just trying to ban an invalid player. My guess is that you run an old version because from what I saw, I didn't see a reason why this would happen.

lunatixxx commented 2 years ago

No i have the last version of AC with updated files and SB++. By the way there were two cheaters at same time and both were logged in the file with multiple detections, the error only happened at the moment to ban them so it failed and they could continue to play on server. So if they did got logged i honestly doubt that this is some sort of bypass, also considering that i had no problems with base bans in the past my theory of the translation bug seems more realistic.

I already had the same type of error when i tried to create translation for a few lines of tank_control plugin, basically these lines 245 and 246 gave me the same error as a comparison:

https://github.com/SirPlease/L4D2-Competitive-Rework/blob/c048ca752681436804403dff79ac06016fbe279b/addons/sourcemod/scripting/l4d_tank_control_eq.sp#L245

So i just left it like that as simple as possible as i was not motivated to invest more time to fix it:

if (client == tankClientId) CPrintToChat(client, "{red}<{default}Next Tank{red}> {green}You");
            else CPrintToChat(client, "{red}<{default}Next Tank{red}> {olive}%s", tankClientName);

My sb++ works with smac and it does not translate the ban reason to everyone, which your plugin is trying to do if i understood well the code.

Anyway as a test i replaced lilac_ban_forward by smac_ban and will see if it makes a difference, i'll tell you when i have more logs but i really think that this is the problem.

J-Tanzanite commented 2 years ago

Any updates?

J-Tanzanite commented 2 years ago

Closing this due to lack of replies.

mrdiega commented 1 year ago
L 03/19/2023 - 19:18:04: [SM] Exception reported: Translation failed: invalid client index 1601069410 (arg 6)
L 03/19/2023 - 19:18:04: [SM] Blaming: lilac.smx
L 03/19/2023 - 19:18:04: [SM] Call stack trace:
L 03/19/2023 - 19:18:04: [SM]   [0] Format
L 03/19/2023 - 19:18:04: [SM]   [1] Line 259, lilac\lilac_stock.sp::lilac_ban_client
L 03/19/2023 - 19:18:04: [SM]   [2] Line 369, lilac\lilac_aimbot.sp::lilac_detected_aimbot
L 03/19/2023 - 19:18:04: [SM]   [3] Line 310, lilac\lilac_aimbot.sp::timer_check_aimbot

[Lilac] Little Anti-Cheat (1.7.4) by J_Tanzanite Material Admin (0.8.6-ae3f5b9) by Material Admin Dev Team game: css v92

J-Tanzanite commented 1 year ago
L 03/19/2023 - 19:18:04: [SM] Exception reported: Translation failed: invalid client index 1601069410 (arg 6)
L 03/19/2023 - 19:18:04: [SM] Blaming: lilac.smx
L 03/19/2023 - 19:18:04: [SM] Call stack trace:
L 03/19/2023 - 19:18:04: [SM]   [0] Format
L 03/19/2023 - 19:18:04: [SM]   [1] Line 259, lilac\lilac_stock.sp::lilac_ban_client
L 03/19/2023 - 19:18:04: [SM]   [2] Line 369, lilac\lilac_aimbot.sp::lilac_detected_aimbot
L 03/19/2023 - 19:18:04: [SM]   [3] Line 310, lilac\lilac_aimbot.sp::timer_check_aimbot

[Lilac] Little Anti-Cheat (1.7.4) by J_Tanzanite Material Admin (0.8.6-ae3f5b9) by Material Admin Dev Team game: css v92

Did you install the latest translations? You'll need those.

Also, CSS v92 is not supported, you can try to use Lilac, but be aware there may be issues. Make sure you've set these ConVars like so:

lilac_angles 0
lilac_angles_patch 0