search

J-The-Fox / FRC-Team-5098

The FRC team 5098 GitHub repo!
https://northtownrobotics.com/
GNU General Public License v3.0
3 stars 1 forks source link

Switch from current controller classes to `XboxController` and `PS4Controller` #15

Closed J-The-Fox closed 10 months ago

J-The-Fox commented 10 months ago

Overview

Switch our current controller model from using all custom controller classes at project_root/main-bot/src/main/java/frc/controllers to using classes underlined in the edu.wpi.first.wpilibj package when applicable. Docs here

The classes underlined in the edu.wpi.first.wpilibj package are the XboxController class for controlling both Xbox360 and XboxOne controllers and the PS4Controller class for controlling a PS4 controller.

This would help eliminate some of the redundant code that we have for controllers. This would not remove the need for a controller folder however as only Xbox and PS4 controllers have classes. Any other controller needs it's own class using the edu.wpi.first.wpilibj.Joystick class

J-The-Fox commented 10 months ago

Update

This has been done on my end, however I have not pushed to this repository as of yet. This is because I am working on fixing lint issues and will push those alongside this

Expect the next push to contain a lot of changes in regards to java docs and formatting for both Java and Python code

I will close this issue as completed since it is just waiting on a push that is completed