nus-pe-bot
commented
5 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Lack of utility of the patient hospital ID field
Expected
The unique identifier associated with each patient is important and should be used to power the various different commands in the application for maximum user friendliness. For instance, new nurses who are unfamiliar with the patients' names or are dealing with large patient lists may find it much easier to use the hospital IDs directly instead of having to use the INDEX in the contact list itself to identify which patients they wish to edit, add tags or delete tags etc.
Actual
The patient hospital ID is only used to verify if patients are unique within the application, but not used for anything else.
[original: nus-cs2103-AY2324S2/pe-interim#2670] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Hi, thanks for pointing this out! :3
However, the purpose of the PatientHospitalId is indeed mainly for the duplicate checks.
This is because PatientSync is intended to be used by nurses beyond the professional level (as mentioned in our DG) and thus, we believe that overly relying on the PatientHospitalId would negate the usefulness of PatientSync by allowing nurses to simply remember their patients by their hospital Ids, which is not the purpose of PatientSync. PatientSync is to be used for nurses to be able to get more familiar with, and thus provide better care for their patients (hence the Food Preference, Hobby, etc. fields).
Additionally, the usage of the list Index for various commands is also to make it more convenient for users after running
sort,find, etc. commands where the order can change and the user can then simply refer to the GUI to perform their subsequent commands.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Expected
The application uses Patient Hospital ID to identify users such that nurses will always know which
Actual
Most commands such as edit, addt, deletet etc. uses Index to identify which user to edit. However, this may be a problem when the list gets very large and the nurses have to scroll all the way down to find the patient they need to edit. Furthermore, with each addition and deletion of a patient from the system, this number changes, adding to the inconvenience.