search

J0 / phoenix_gen_socket_client

Socket client behaviour for phoenix channels
MIT License
232 stars 48 forks source link

add support for returning {:connect, url, query_params, state} from a… #30

Closed boydm closed 6 years ago

boydm commented 6 years ago

Add support for returning {:connect, url, query_params, state) from handle_info callbacks. This will allow the socket to connect to a different url and/or tokens/params that it was initially set up with.

Also updated tests and the readme documentation.

I did not add it to the changelist as you should pick what version number you want to call it.

Also tested calling it from the code I'm working on and it does what I need.

boydm commented 6 years ago

Arg. Forgot to run the code formatter... will do in a sec.

boydm commented 6 years ago

Added docs for TestSocket.connect/3

Was there another one you were referring to? That's the only one I saw that needed it.

sasa1977 commented 6 years ago

That was it, thanks!

I'll see about bumping the minor version and releasing in the next few days.

boydm commented 6 years ago

Thank you much

sasa1977 commented 6 years ago

FYI 2.1.0 is now published at hex.pm