search

J0 / phoenix_gen_socket_client

Socket client behaviour for phoenix channels
MIT License
232 stars 48 forks source link

Replaces Poison with Jason #41

Closed gottfrois closed 4 years ago

gottfrois commented 4 years ago

Based on https://github.com/Aircloak/phoenix_gen_socket_client/pull/40/files minus the noise around fixing various warnings.

gottfrois commented 4 years ago

@xadhoom feedback welcome mate ;)

gottfrois commented 4 years ago

@xadhoom hey mate, any chance to merge this PR anytime soon? :)

xadhoom commented 4 years ago

hey @gottfrois I'm not the maintainer, I think @sasa1977 should be pinged ;)

sasa1977 commented 4 years ago

Since I'm not with Aircloak anymore, I don't maintain this either, i.e. I don't have any permissions to merge . Let's ping @sebastian and see if he can help :-)

sebastian commented 4 years ago

Sorry for letting this pull-request hang for so long @gottfrois! Somehow I didn't have notifications turned on for this repo!

I'll take a look when back at the office next week.

gottfrois commented 4 years ago

@xadhoom ah sorry about that mate! 🤣 @sebastian sounds great!

sebastian commented 4 years ago

Thank you for the pull-request @gottfrois.

sebastian commented 4 years ago

Thank you again for this pull-request. I have published a new version containing your changes.