Changes for new version of the lib

J0 / phoenix_gen_socket_client

Socket client behaviour for phoenix channels

MIT License

232 stars 48 forks source link

Changes for new version of the lib #44

Closed sebastian closed 4 years ago

sebastian commented 4 years ago

Closes #45

sebastian commented 4 years ago

@sasa1977 could you please provide some insight here. The past pull-request which replaced the Poison as a JSON encoding library with Jason seems like a breaking change. Agreed? Hence we are really forced to make a major release out of this... somewhat annoying given there are no real changes in the library to speak of... Just wanted to hear your opinion before making this bump.

sebastian commented 4 years ago

Never mind, @sasa1977. Seems my hand is forced anyway. To support more modern Elixir versions I had to upgrade the version of some other dependencies, which in turn prevented me from testing against older versions of Elixir.

Major version it is.