Fix call/3 function spec

J0 / phoenix_gen_socket_client

Socket client behaviour for phoenix channels

MIT License

232 stars 48 forks source link

Fix call/3 function spec #50

Closed matt-mazzucato closed 3 years ago

matt-mazzucato commented 3 years ago

Since GenSocketClient.call/3 has the same signature of GenServer.call/3, make the specs coincident. This change prevents type checking tools (such as dialyzex) from raising errors due to the fact that :infinity breaks the contract.

sebastian commented 3 years ago

Thank you @matt-mazzucato!

sebastian commented 3 years ago

I just released version 3.1.0 containing your fix. Thanks again.