search

J0 / phoenix_gen_socket_client

Socket client behaviour for phoenix channels
MIT License
232 stars 48 forks source link

Allow passing options to serializer for decoding based on the opcode (:text or :binary) #58

Closed cabol closed 3 years ago

cabol commented 3 years ago

Currently, since the opcode is not being passed to the serializer, it is not possible to know if it is text or binary, and this may be helpful to know whether to decode/encode a JSON-text or a binary – for example, be able to do something like https://github.com/phoenixframework/phoenix/blob/master/lib/phoenix/socket/serializers/v2_json_serializer.ex#L102-L108

sebastian commented 3 years ago

Dear @cabol, thank you for your contribution.

The pull-request changes the API in a breaking way. This would require a new major release with the corresponding accompanying effort. We are no longer maintaining this library. You can find more information here: https://github.com/Aircloak/phoenix_gen_socket_client/issues/57

If you are interested in taking over the stewardship of this library, please let me know.

As it is, we are no longer accepting further contributions.

J0 commented 3 years ago

Hi @cabol,

Thank you for your contribution! I have just taken over the project and am pondering next steps. l'll get back to you shortly on this PR(hopefully by the end of next week). In the meantime, feel free to join the Gitter Chat or post any suggestions you have for the project here.

Thanks!

J0 commented 3 years ago

Hey @cabol,

Just wanted to just update you and let you know that I haven't forgotten about this thread. I've looked through the PR and it seems fine to me. However, as this involves a breaking change and consequently a release, I'd like to take sometime to see if there are any other changes we should rollout.

As such, I will only be merging this PR tomorrow once I have aggregated any other potential changes. Once again, thank you for your contribution and continued patience.

cabol commented 3 years ago

Hi @J0, thanks for the answer, it sounds good to me, totally understand, I stay tuned, thanks!!