search

J0R6IT0 / lyricsfinder

1 stars 0 forks source link

Issue with searching for lyrics #1

Closed Mar0xy closed 3 years ago

Mar0xy commented 3 years ago

I have noticed that for some reason I have to call the findLyrics function multiple times to get lyrics and I don't know how this issue comes around. In the picture below I ran the command three times to finally get the lyrics image

Mar0xy commented 3 years ago

Here is another example image

J0R6IT0 commented 3 years ago

Hey, thanks for reporting! Does it happen with every song?

J0R6IT0 commented 3 years ago

ouch, working fine on my end x.x. I'll try to find what's going on.

J0R6IT0 commented 3 years ago

Published a new update. Try it and lemme know if it works better. Genius sometimes doesn't return a proper html with lyrics, even when using the same url, so the module falls back to Google. But apparently sometimes the Google scraper doesn't work for about 0.5-1h. Not sure why, maybe updates going on in Google.

Now it will try several times to get the lyrics from Genius (if song is found).

Mar0xy commented 3 years ago

Yep that fixed the issue I was having 👍 As far as I know Google generally is very unreliable as a source to get lyrics due to reasons like that which is why a lot of service/modules tend to only use Genius or Musixmatch

J0R6IT0 commented 3 years ago

Cool! Lemme know if you find any other bug. 🙂