J2Store4 / j2store4

J2Store 4 - Open Source eCommerce extension for Joomla
https://www.j2store.org
GNU General Public License v3.0
15 stars 7 forks source link

Download Item issue #14

Closed coolcat-creations closed 5 months ago

coolcat-creations commented 1 year ago

I am referring to this issue: https://github.com/J2Store4/j2store4/pull/7#issuecomment-1689365621 can you fix this?

mgopin3 commented 10 months ago

I understand your concern. We have conducted tests on our local site and confirmed that the downloadable product path is functioning correctly, with downloads occurring without any issues. We have also thoroughly reviewed the code, and all conditions related to the download path are working properly.

Therefore, it's possible that the issue may be due to the file path not existing on your site. Please verify whether the path exists on your site or not. For your reference, please view this video: https://www.awesomescreenshot.com/video/21689182?key=68e41a93e57599e05319a3d590c76a9d.

mgopin3 commented 6 months ago

@coolcat-creations We believe the reported issue has been addressed. Could you please confirm that the problem is resolved on your end? If everything looks good, we'll go ahead and close this issue.

If you have any further questions or if there's anything else you'd like assistance with, please don't hesitate to let us know. We appreciate your feedback!

coolcat-creations commented 6 months ago

I dont know because I corehacked the file, can you direct me to the change that had been done so I can check?

mgopin3 commented 5 months ago

@coolcat-creations Navigate to J2Store -> Setup -> Configuration. In the Basic Settings tab, locate the "Folder Path for Digital Goods" field [Image].In this field, specify the folder path that corresponds to the location of the files you typically select in the Files section when configuring Downloadable Products. After a purchase, the system will verify the file extension under the specified "Folder Path for Digital Goods" to ensure the existence of the file before displaying the download button and initiating the download process. This validation step ensures a seamless and secure download experience for customers.Hope you understand

coolcat-creations commented 5 months ago

No, I meant can you show me the line you fixed in j2Store (php) so I can compare with the core hacked version?

mgopin3 commented 5 months ago

@coolcat-creations This relates to the file located at the following path: /administrator/components/com_j2store/models/orderdownloads.php, specifically in the getFilePath() function around line 399. In this function, we have implemented a check to verify the existence of the file path before displaying the download button and initiating the download process.

mgopin3 commented 5 months ago

@coolcat-creations We believe the reported issue has been addressed. Could you please confirm that the problem is resolved on your end? If everything looks good, we'll go ahead and close this issue.

If you have any further questions or if there's anything else you'd like assistance with, please don't hesitate to let us know. We appreciate your feedback!