J35P312 / SVDB

structural variant database software
MIT License
38 stars 16 forks source link

update tmp file names #62

Closed ramprasadn closed 1 year ago

ramprasadn commented 1 year ago

This PR modifies the output file names for the intermediary files when the user provides a list of databases as an input.

Rationale:

When there is an issue with one of the databases in the list of dbs provided by the user, svdb throws an error. However, this doesn't work well when svdb is run as a process in nextflow, where the process is expecting a ".vcf" output to determine successful completion. In such cases it simply picks up one of the intermediary files with a ".vcf" extension and proceeds as if there were no errors.

codecov-commenter commented 1 year ago

Codecov Report

Base: 17.88% // Head: 17.85% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (384252b) compared to base (231de54). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #62 +/- ## ========================================== - Coverage 17.88% 17.85% -0.03% ========================================== Files 10 10 Lines 1275 1277 +2 ========================================== Hits 228 228 - Misses 1047 1049 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `17.85% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/J35P312/SVDB/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt) | Coverage Δ | | |---|---|---| | [svdb/\_\_main\_\_.py](https://codecov.io/gh/J35P312/SVDB/pull/62/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt#diff-c3ZkYi9fX21haW5fXy5weQ==) | `0.00% <0.00%> (ø)` | | | [svdb/query\_module.py](https://codecov.io/gh/J35P312/SVDB/pull/62/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt#diff-c3ZkYi9xdWVyeV9tb2R1bGUucHk=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jesper+Eisfeldt)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

J35P312 commented 1 year ago

Hello! Nice stuff! Could you bump the version number in setup.py and main? THen I will merge! Thanks! //Jesper

J35P312 commented 1 year ago

Nice!