Keybindings

[harman28]

Added keybindings for a variety of actions, in response to #36

• Entity index views: n -> new entity form.
• All pages with single submit button: enter -> submit result page.
• Any app page:
  • 1 -> Home view
  • 2 -> Tags index view
  • 3 -> Tasks index view
  • 4 -> Time Entries index view

@J3RN Please have a look.

[J3RN]

Hey @harman28! :wave:

Thanks for this PR! I'm a little skeptical about adding another dependency, though... Especially because it looks like Mousetrap hasn't been updated in the last year.

Instead of using Mousetrap, I implemented the same functionality in what I hope is easily understandable CoffeeScript using jQuery:

$ ->
  handleKeyBindings()

$(document).on 'page:change', ->
  handleKeyBindings()

handleKeyBindings = ->
  # Elements that, when active, do not trigger a page change
  blacklist = [ "input", "select" ]
  # Key-to-url bindings
  bindings = {}

  # Store all `data-keybinding` attributes with their corresponding URLs
  $('a[data-keybinding]').each (i, el) ->
    key = $(el).data("keybinding")
    bindings[key] = $(el).attr('href')

  # Detect a keypress and navigate to the proper URL if appropriate
  $('body').keypress (e) ->
    if bindings[e.key] != undefined and !$(document.activeElement).is(blacklist.join(","))
      window.location.href = bindings[e.key]

Would you mind migrating to this script instead? I think it's just simpler all around.

To do so, you can:

• [x] Change the contents of app/assets/javascripts/keybindings.js.coffee to the code above
• [x] Remove app/assets/stylesheets/mousetrap.scss
• [x] Remove changes to
  • [x] Gemfile
  • [x] Gemfile.lock
  • [x] app/assets/javascripts/application.js
  • [x] app/assets/stylesheets/application.scss

Let me know what you think! 🤔

[harman28]

@J3RN Makes sense. I've made the changes. Please have another look whenever convenient.

[harman28]

@J3RN Made the changes you suggested. Have a look.

[J3RN]

This looks good! Thanks, @harman28!