J3fftw1 / LiteXpansion

GNU General Public License v3.0
1 stars 0 forks source link

[BUG] Able to create any item using the Mass Fabricator #120

Closed AlexLander123 closed 3 years ago

AlexLander123 commented 3 years ago

Description (REQUIRED)

The Mass Fabricator will create the item in the output slot regardless of the type of item. This is due to the Mass Fabricator increasing the amount of the itemstack in the output slot by 1 (MassFabricator.java#L126) without prior checking on whether the item in the output slot is a UU-Matter.

Steps to reproduce the Issue (REQUIRED)

  1. Insert an item into the output slot of the Mass Fabricator by selecting the item and hold right click while hovering over the output slot.
  2. Insert sufficient Scrap to produce a UU-Matter (200 Scrap) into the input slot of the Mass Fabricator.
  3. The itemstack in the output slot will increase by 1.

GIF showing the creation of a Cargo Node (Output): LiteXpansion Bug

Expected behavior (REQUIRED)

The Mass Fabricator should not work if the output slot has an itemstack that is not UU-Matter.

Server Log

There is no errors.

Environment (REQUIRED)