Made solar panels look nicer and easier to understand

NCBPFluffyBear commented 4 years ago

Short Description

Moved j/t to j/t methods to Utils and Constants, Added more information to solar panel guis, condensed messages to prevent running off screen.

Moved J/t to J/s conversion to Utils (perTickToPerSecond)
Moved and combined decimal formatting and fading to Utils (powerFormatAndFadeDecimals)
Moved Minecraft tick rate and Slimefun tick delay to Constants
Modified solar panel gui to use orange stained glass when full instead of red stained glass to look less like an error
Modified solar panel gui lore to state if it is day or night
Modified solar panel gui lore to display both J/s and J/t

N/A

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
[x] I followed the existing code standards and didn't mess up the formatting.
[x] I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers. Code should be easy to follow, method names are self explanatory
[x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values Didn't deal with any null values... I think

NCBPFluffyBear commented 4 years ago

J3fftw1 commented 4 years ago

Stored amount isnt correct it doesnt do 419.840

NCBPFluffyBear commented 4 years ago

Wut it isnt full

NCBPFluffyBear commented 4 years ago

If it were full then it would tell me it is full and the panel would be orange

J3fftw1 commented 4 years ago

it doesnt have formatting like everything else

NCBPFluffyBear commented 4 years ago

Ah ok ill get that fixed

NCBPFluffyBear commented 4 years ago

WalshyDev commented 4 years ago

Any comment about implementation @J3fftw1 ?

NCBPFluffyBear commented 4 years ago

Im going to wait for this pr to be over before fixing the rubber stuff so that the changelogs dont exclude random stuff

WalshyDev commented 4 years ago

Im going to wait for this pr to be over before fixing the rubber stuff so that the changelogs dont exclude random stuff

Firstly, we don't have changelogs. Secondly, you can just make another branch. It's why branches exist.

NCBPFluffyBear commented 4 years ago

o das true... also I meant the repo server logs

J3fftw1 commented 4 years ago

If thats changed its ready for merge